Hypervisor: L1TLB PLRU updated by sector hit mismatching Virtual bit #2952
+22
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: after #2841
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
The
sectorHitfunction in the TLB is used for PLRU updates and inserting new entries in the same sector.The
TLBEntry.hitfunction includes bothvpnandvirtualarguments to distinguish between HS/HU or VS/VU entries, but thesectorHitfunction does not. This won’t cause problems when inserting new entries in the same sector, but can allow misses due to mismatching Virtual bit to still update the PLRU as if they were a hit.virtualargument to theTLBEntry.sectorHitfunction.vbit fromTLBEntryDatato be a single tag bit alongsidevpn.